[SYCL] Remove kernel_signature_start from int header #2537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago, the `kernel_signatures` array used `kind_none` as a delimiter between signatures of different kernels. The `kernel_signature_start` array's values were computed with a `+ 1` to account for this. Then one day the delimiter was removed but the `+ 1` remained. It wasn't noticed that the values were off by 1 because `kernel_signature_start` isn't being used anymore anyway. Therefore in this change, we simply remove it. GH issue #2490
jtmott-intel
requested review from
Fznamznon,
elizabethandrews and
premanandrao
as code owners
kbobrovs
approved these changes
Sep 25, 2020
erichkeane
approved these changes
Sep 25, 2020
romanovvlad
approved these changes
Sep 25, 2020
premanandrao
approved these changes
Sep 25, 2020
elizabethandrews
approved these changes
Sep 25, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Sep 29, 2020
…_wrapper * upstream/sycl: (1533 commits) [SYCL] XFAIL sub_group shuffle tests on GPU [SYCL] Add support for L0 loader validation layer (intel#2520) [NFC][LIT] Temporary disable function pointers as they hang on L0 (intel#2544) [SYCL] use release version of OpenCL ICD loader [SYCL] Improve testing of host-task (intel#2540) Revert 1291215 [SYCL] Fix warning caused by [[nodiscard]] attribute (intel#2545) [SYCL] Workaround windows build failure [SYCL] Remove kernel_signature_start from int header (intel#2537) [SYCL] Fix ABI tests in post-commit (intel#2539) [SYCL][DOC] Update C-CXX-StandardLibrary doc to align with latest status (intel#2529) [SYCL][NFC] Fix static code analysis concerns (intel#2531) [SYCL][NFC] Improve testing for accessor_property_list (intel#2532) [SYCL] Avoid overuse of CPU on wait read-write lock loop (intel#2525) [SYCL] Implement no-decomposition for kernel types that don't need it. (intel#2477) [SYCL] Add group algorithm constraints (intel#2462) [BuildBot] Uplift Windows GPU RT from 8673 to 8778 (intel#2533) [SYCL][LIT][NFC] Extend ABI test suite (intel#2522) [SYCL][DebugInfo] Reinstate source locations for some kernel instructions (intel#2527) [SYCL][NFC] Replace the deprecated VectorType::getNumElements() (intel#2524) ...
iclsrc
pushed a commit
that referenced
this pull request
May 2, 2024
The SPIR-V Validator has recently started checking for duplicate decorations. This commit fixes duplicate Alignment decorations that affected the `test/read_image.cl` test. Alignment decorations have two potential sources during LLVM to SPIR-V translation: the instruction's alignment property and `spirv.Decorations` metadata. Handle both of these through the `setAlignment` method, so that duplicates can be avoided. Calling `setAlignment` with different alignments for the same entity is probably an error, so add an assert. Contributes to KhronosGroup/SPIRV-LLVM-Translator#2509 Original commit: KhronosGroup/SPIRV-LLVM-Translator@926ca2ae8497166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, the
kernel_signaturesarray usedkind_noneas a delimiter between signatures of different kernels. Thekernel_signature_startarray's values were computed with a+ 1to account for this. Then one day the delimiter was removed but the+ 1remained. It wasn't noticed that the values were off by 1 becausekernel_signature_startisn't being used anymore anyway. Therefore in this change, we simply remove it.GH issue #2490