[SYCL][WIP-DO-NOT-MERGE] Update namespaces of oneAPI and Intel extensions #2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
jbrodman
requested review from
a team,
AlexeySachkov,
MrSidims,
Pennycook,
kbobrovs and
v-klochkov
as code owners
Signed-off-by: James Brodman <[email protected]>
Contributor
Author
|
/summary:run |
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Contributor
|
I'm fine with updating namespaces in general and for FPGA in particular, but would like to hear from @GarveyJoe |
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
… fix. Signed-off-by: James Brodman <[email protected]>
jbrodman
requested review from
Fznamznon,
elizabethandrews and
premanandrao
as code owners
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
kbobrovs
reviewed
Jul 27, 2020
Contributor
kbobrovs
left a comment
kbobrovs
left a comment
There was a problem hiding this comment.
I think moving spec constant implementation from experimental to ext::oneapi is premature. Those APIs are known to get deprecated with SYCL 2020 and replaced with new ones.
Signed-off-by: James Brodman <[email protected]>
Contributor
I think this will break most of our existing tests and code samples. Can you stagger the change? I.e. initially include the functions in both namespaces to give us time to convert our code and then after a grace period remove support for the old namespace? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to extensions in DPC++: