Skip to content

Conversation

@mateuszpn
Copy link
Contributor

@mateuszpn mateuszpn commented Dec 5, 2025

The fix allows to use of _v1 and _v2 to select the l0 adapter and the use of arch to select the GPU, eg.:
llvm-lit --param "sycl_devices=level_zero_v2:arch-intel_gpu_mtl_u"
Necessary to run tests on integrated GPU on system with another GPU

Signed-off-by: Mateusz P. Nowak <[email protected]>
Signed-off-by: Mateusz P. Nowak <[email protected]>
@mateuszpn mateuszpn marked this pull request as ready for review December 10, 2025 13:40
@mateuszpn mateuszpn requested a review from a team as a code owner December 10, 2025 13:40
@KFilipek KFilipek changed the title {SYCL][E2E] Fix lit to use arch selection and l0 v2 adapter [SYCL][E2E] Fix lit to use arch selection and l0 v2 adapter Dec 10, 2025
"linux",
"windows",
"preview-breaking-changes-supported",
# the following entries are used by architecture-based filtering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry can you point out which part fixes the CI failures?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a device is specified as :arch-, it doesn't contain generic :gpu or :cpu - and the tokens were normally used when parsing conditions like %if gpu in tests. Now, if only gpu exist in test.config.available_features, tests still can use %if gpu.
After reconsidering - architecture-based device selection makes sense only for GPUs, so "cpu" and "accelerator" will never be used and can be removed (they will work as before if
device name is like opencl:cpu)

features.update(architecture_feature)
features.update(device_family)

be, dev = sycl_device.split(":")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would expect dev to be arch-intel_gpu_mtl_u or whatever, but i see isdigit check so what would the digits be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the time we hit features.add(dev) sycl_device is already resolved SYCL name, eg. level_zero:1, not level_zero_v2:arch-intel_gpu. If the device name is given as :arch-, we have digit after colon, if it was generic (eg. :gpu) it is still generic.

@sarnex sarnex merged commit 32fd3bc into intel:sycl Dec 11, 2025
59 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants