Skip to content

[SYCL][Unittests] Fix IPC unittests #20804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
+11 −6
Open

[SYCL][Unittests] Fix IPC unittests #20804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sycl/unittests/Extensions/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@ add_subdirectory(VirtualMemory)
add_subdirectory(NumComputeUnits)
add_subdirectory(FreeFunctionCommands)
add_subdirectory(KernelQueries)
add_subdirectory(InterProcessCommunication)
4 changes: 2 additions & 2 deletions sycl/unittests/Extensions/InterProcessCommunication/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ add_sycl_unittest(IPCTests OBJECT
Memory.cpp
)

set_target_properties(IPCTests_preview PROPERTIES CXX_STANDARD 20)
set_target_properties(IPCTests_non_preview PROPERTIES CXX_STANDARD 20)
set_target_properties(IPCTests_Preview_Tests PROPERTIES CXX_STANDARD 20)
set_target_properties(IPCTests_Non_Preview_Tests PROPERTIES CXX_STANDARD 20)
12 changes: 8 additions & 4 deletions sycl/unittests/Extensions/InterProcessCommunication/Memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,10 @@ TEST_F(IPCTests, IPCGetPutImplicit) {
syclexp::ipc_memory::handle IPCMemHandle =
syclexp::ipc_memory::get(DummyPtr, Ctxt);
syclexp::ipc_memory::handle_data_t IPCMemHandleData = IPCMemHandle.data();
EXPECT_EQ(IPCMemHandleData.size(), DummyHandleDataSize);
EXPECT_EQ(IPCMemHandleData.data(), DummyHandleData);
ASSERT_EQ(IPCMemHandleData.size(), DummyHandleDataSize);
EXPECT_EQ(std::memcmp(IPCMemHandleData.data(), DummyHandleData,
DummyHandleDataSize),
0);

// Creating the IPC memory from a pointer should only call "get".
EXPECT_EQ(urIPCGetMemHandleExp_counter, 1);
Expand All @@ -126,8 +128,10 @@ TEST_F(IPCTests, IPCGetPutExplicit) {
syclexp::ipc_memory::handle IPCMemHandle =
syclexp::ipc_memory::get(DummyPtr, Ctxt);
syclexp::ipc_memory::handle_data_t IPCMemHandleData = IPCMemHandle.data();
EXPECT_EQ(IPCMemHandleData.size(), DummyHandleDataSize);
EXPECT_EQ(IPCMemHandleData.data(), DummyHandleData);
ASSERT_EQ(IPCMemHandleData.size(), DummyHandleDataSize);
EXPECT_EQ(std::memcmp(IPCMemHandleData.data(), DummyHandleData,
DummyHandleDataSize),
0);

// Creating the IPC memory from a pointer should only call "get".
EXPECT_EQ(urIPCGetMemHandleExp_counter, 1);
Expand Down
Loading