[SYCL][L0 v2] Use counter-based events #20788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
changed the title
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
|
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Mateusz P. Nowak <[email protected]>
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Mateusz P. Nowak <[email protected]>
kswiecicki
requested changes
Dec 4, 2025
| (platform->ZeDriver, "zexCounterBasedEventCreate2", | ||
| (void **)&this->eventCreateFunc)); | ||
| if (result != ZE_RESULT_SUCCESS) { | ||
| throw ur_result_t(ze2urResult(result)); |
Contributor
There was a problem hiding this comment.
I'm pretty sure that ZE2UR_CALL_THROWS does what you are doing here, it also prints an error message when UR_ENABLE_ASSERTIONS is enabled in cmake.
| // If counter-based events are not supported, fall back to normal events | ||
| // Remove the counter flag as the normal provider doesn't support it | ||
| event_flags_t normalFlags = flags & ~EVENT_FLAGS_COUNTER; | ||
| return std::make_unique<provider_normal>(context, queueType, normalFlags); |
Contributor
There was a problem hiding this comment.
provider_normal still supports the counter events, it just uses the old API to do that. provider_counter throwing an exception would mean that the zexCounterBasedEventCreate2 function is unavailable, not that counter-based events aren't supported.
provider_normal should be used when EVENT_FLAGS_COUNTER is not set or provider_counter has thrown an error because zexCounterBasedEventCreate2 is unavailable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use counter-based events in level-zero v2 adapter