-
Notifications
You must be signed in to change notification settings - Fork 798
[SYCL] Remove devicelib jit link #20777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Hi, @bader |
sarnex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake lgtm
aelovikov-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not familiar with that area so I'll refrain from formally approving for now, to let others a chance to look at it. Feel free to ping me again for a formal approval in a few days if nobody replies by then.
|
Similar situation from dpcpp-tools perspective: LGTM, but I was not aware of this deprecation/removal, so would like someone else to formally approve. Or if you can share any documentation with me, would be great. Feel free to ping me, if nobody else approves. |
bader
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update the PR description according to the contribution guide.
Specifically (from https://llvm.org/docs/DeveloperPolicy.html#commit-messages):
The body should be concise, but explanatory, including a complete rationale. Unless it is required to understand the change, examples, code snippets and gory details should be left to bug comments, web review or the mailing list.
Signed-off-by: jinge90 <[email protected]>
The '-fsycl-device-lib-jit-link' option has been removed in #20326. This PR cleans up sycl-post-link and sycl runtime code to support this option. The removed code includes: