Skip to content

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Nov 28, 2025

The '-fsycl-device-lib-jit-link' option has been removed in #20326. This PR cleans up sycl-post-link and sycl runtime code to support this option. The removed code includes:

  1. Analysis in sycl-post-link tool to record which device libraries are used by user's device image via image property
  2. Program manager handling for device library require mask property to decide which fallback spv will be loaded and linked during execution time.
  3. Program manager utils to read/load device library fallback spv files into memory and utils to link in-memory spv device library modules with user's module.

@jinge90 jinge90 requested a review from a team as a code owner November 28, 2025 07:54
@jinge90 jinge90 marked this pull request as draft November 28, 2025 07:55
@jinge90 jinge90 marked this pull request as ready for review December 2, 2025 05:02
@jinge90 jinge90 requested a review from bader December 2, 2025 05:02
@jinge90
Copy link
Contributor Author

jinge90 commented Dec 2, 2025

Hi, @bader
This PR removes sycl device library jit link path in both sycl runtime and sycl-post-link tool. Could you help review it?
Thanks very much.

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake lgtm

@sarnex sarnex requested review from a team December 2, 2025 15:22
@jinge90 jinge90 changed the title [SYCL][WIP] Remove devicelib jit link [SYCL] Remove devicelib jit link Dec 2, 2025
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not familiar with that area so I'll refrain from formally approving for now, to let others a chance to look at it. Feel free to ping me again for a formal approval in a few days if nobody replies by then.

@YuriPlyakhin
Copy link
Contributor

Similar situation from dpcpp-tools perspective: LGTM, but I was not aware of this deprecation/removal, so would like someone else to formally approve. Or if you can share any documentation with me, would be great. Feel free to ping me, if nobody else approves.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the PR description according to the contribution guide.

Specifically (from https://llvm.org/docs/DeveloperPolicy.html#commit-messages):

The body should be concise, but explanatory, including a complete rationale. Unless it is required to understand the change, examples, code snippets and gory details should be left to bug comments, web review or the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants