Skip to content

[SYCL][NFC] Avoid double allocation in device_impl::get_device_info_string #18099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aelovikov-intel merged 2 commits into from
Apr 18, 2025
Merged

[SYCL][NFC] Avoid double allocation in device_impl::get_device_info_string #18099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
996d012
[SYCL][NFC] Avoid double allocation in `device_impl::get_device_info_…
aelovikov-intel Apr 18, 2025
79c78c6
Fix off by one error
aelovikov-intel Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions sycl/source/detail/device_info.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,11 +208,16 @@ device_impl::get_device_info_string(ur_device_info_t InfoCode) const {
if (resultSize == 0) {
return std::string();
}
std::unique_ptr<char[]> result(new char[resultSize]);
std::string result;
// C++23's `resize_and_overwrite` would be better...
//
// UR counts null terminator in the size, std::string doesn't. Adjust by "-1"
// for that.
result.resize(resultSize - 1);
getAdapter()->call<UrApiKind::urDeviceGetInfo>(
getHandleRef(), InfoCode, resultSize, result.get(), nullptr);
getHandleRef(), InfoCode, resultSize, result.data(), nullptr);

return std::string(result.get());
return result;
}

// Specialization for string return type, variable return size
Expand Down