Skip to content

Conversation

@romanovvlad
Copy link
Contributor

No description provided.

@romanovvlad romanovvlad requested a review from pvchupin as a code owner May 18, 2020 17:32
pvchupin
pvchupin previously approved these changes May 18, 2020
version below 16.3.0
The workaround is to enable `-std=c++17` for the failing MSVC version.

## Prerequisites
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should point to exact revision of https://github.com/intel/llvm/blob/sycl/buildbot/dependency.conf used for testing 67d3d9e.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably just remove prerequisites from release notes, but we need GetStartedGuide.md update first.
Basically idea is that dependency.conf for corresponding tag or any commit should always point to the recommended dependencies for this commit.
I also don't want to block May'20 release notes by this cleanup needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1699 is in progress, so let's remove prerequisites from here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

version below 16.3.0
The workaround is to enable `-std=c++17` for the failing MSVC version.

Please, see the runtime installation guide [here](https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md#install-low-level-runtime)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@romanovvlad romanovvlad requested a review from pvchupin May 21, 2020 09:28
@romanovvlad
Copy link
Contributor Author

Added new known issue while the patch is still on review.

@bader bader merged commit b1c0e65 into intel:sycl May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants