[Driver][SYCL][FPGA] Adjust the output location for the project report #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no output specifier is given on the command line, create the output project report location in the $CWD as opposed to matching the source location if it was specified with a directory. Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
reviewed
Mar 10, 2020
meiyacha
reviewed
Mar 10, 2020
Signed-off-by: Michael D Toguchi <[email protected]>
Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
reviewed
Mar 11, 2020
Invalid type check needed as the check was for an extension type and not directly associated with the validity of it being an input. Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no output specifier is given on the command line, create the output
project report location in the $CWD as opposed to matching the source location
if it was specified with a directory.
Signed-off-by: Michael D Toguchi [email protected]