[SYCL][Fusion] Enable fusion of rounded-range kernels #12492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopperm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jopperm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sommerlukas
reviewed
Jan 25, 2024
Contributor
sommerlukas
left a comment
sommerlukas
left a comment
There was a problem hiding this comment.
LGTM, just one question inline.
jopperm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jopperm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sommerlukas
approved these changes
Jan 26, 2024
victor-eds
reviewed
Jan 26, 2024
jopperm
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
Signed-off-by: Julian Oppermann <[email protected]>
victor-eds
approved these changes
Jan 30, 2024
Contributor
Author
|
@intel/llvm-gatekeepers Could you merge this, please? |
sommerlukas
pushed a commit
that referenced
this pull request
Jan 31, 2024
Silence unused variable warning which tripped post-commit checks for #12492. Signed-off-by: Julian Oppermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable, test, and document the support for fusing rounded range kernels. This mostly worked already – we just have to query the original kernel's global size, and use that to compute the private memory size used for internalization.