[SYCL][Graph][L0] Reset L0 events for UR sync-points #11553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Unified Runtime sync-points used to represent SYCL-Graph edges are not correctly implemented for the Level Zero adapter. The L0 events used to implement them are not reset to the non-signalled state after an enqueue of the graph. Fixed in the UR L0 adapter change oneapi-src/unified-runtime#965 which resets the UR events to the non-signalled state at the end of the L0 command-list.
EwanC
commented
Oct 16, 2023
Point to the most recent UR commit for this change and update the design doc diagram to reflect the changes from this patch to L0 command-lists used to implement a UR command-buffer.
EwanC
force-pushed
the
ewan/L0_sync_point_event_reset
branch
from
9dba140 to
68e2d95
Compare
Contributor
Author
|
CI fails on the PR look unrelated.
|
Contributor
thanks @EwanC , For #11312, we are reverting those changes in oneapi-src/unified-runtime#972. Please rebase once that is merged and relaunch. |
kbenzie
reviewed
Oct 26, 2023
mfrancepillois
approved these changes
Oct 26, 2023
smaslov-intel
approved these changes
Oct 26, 2023
Currently Github pr thinks file is invalid
dm-vodopyanov
approved these changes
Oct 27, 2023
Contributor
Author
|
@intel/llvm-gatekeepers Can we merge this to unblock merging the next unified-runtime PR in the queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Unified Runtime sync-points used to represent SYCL-Graph edges have a bug in the implementation of the Level Zero adapter. The L0 events used to implement the sync-points are not reset to the non-signaled state after an enqueue of the graph.
Fixed in the UR L0 adapter change oneapi-src/unified-runtime#965 which resets the UR events to the non-signaled state at the end of the L0 command-list.