Skip to content

[UR] Don't unload UR twice #11527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steffenlarsen merged 1 commit into from
Oct 16, 2023
Merged

[UR] Don't unload UR twice #11527

steffenlarsen merged 1 commit into from
Oct 16, 2023
+0 −1

Conversation

@veselypeta
Copy link
Contributor

@veselypeta veselypeta commented Oct 12, 2023

releaseAdapters will already call urTearDown so we remove this redundant call which was causing segfaults in some cases.

@veselypeta veselypeta requested a review from a team as a code owner October 12, 2023 15:21
@veselypeta veselypeta temporarily deployed to WindowsCILock October 12, 2023 15:31 — with GitHub Actions Inactive
@veselypeta veselypeta temporarily deployed to WindowsCILock October 12, 2023 16:24 — with GitHub Actions Inactive
@jle-quel jle-quel mentioned this pull request Oct 13, 2023
Merged
2 tasks
smaslov-intel
smaslov-intel approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veselypeta
Copy link
Contributor Author

veselypeta commented Oct 16, 2023

@intel/llvm-gatekeepers

@steffenlarsen steffenlarsen merged commit 8c481bd into intel:sycl Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@veselypeta @smaslov-intel @steffenlarsen