Skip to content

[SYCL] Add test for extended deleters #11344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
againull merged 16 commits into from
Oct 20, 2023
Merged

[SYCL] Add test for extended deleters #11344

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5a13e4d
Re add extended deleters
Sep 28, 2023
3460ade
Revert delete call
Sep 28, 2023
310e8d0
Add extended deleters test
Sep 29, 2023
c8267b1
Update sycl/test/extended_deleters/extended_deleters.cpp
hdelan Sep 29, 2023
c7d258b
Revert "Update sycl/test/extended_deleters/extended_deleters.cpp"
Oct 10, 2023
0dc75c2
Remove change to adapter
Oct 10, 2023
bbd1e52
Move test to test-e2e
Oct 13, 2023
650bb36
Change UR repo and sha
Oct 13, 2023
11b9d83
Merge branch 'sycl' into fix-typo-in-hip-adapter
hdelan Oct 13, 2023
d0286d9
Only run for HIP, CUDA
Oct 13, 2023
0f6ee56
Update commit SHA in UR repo
Oct 17, 2023
9aa3a27
Update SHA
Oct 19, 2023
b2993ce
Revert "Update SHA"
Oct 19, 2023
f2489be
Merge branch 'sycl' into fix-typo-in-hip-adapter
Oct 20, 2023
8d05088
Point SHA to reverted commit branch
Oct 20, 2023
9788c42
Update sycl/plugins/unified_runtime/CMakeLists.txt
hdelan Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sycl/plugins/unified_runtime/ur/adapters/hip/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ urContextGetInfo(ur_context_handle_t hContext, ur_context_info_t propName,
UR_APIEXPORT ur_result_t UR_APICALL
urContextRelease(ur_context_handle_t hContext) {
if (hContext->decrementReferenceCount() == 0) {
hContext->invokeExtendedDeleters();
delete hContext;
}
return UR_RESULT_SUCCESS;
Expand Down
16 changes: 16 additions & 0 deletions sycl/test/extended_deleters/extended_deleters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// RUN: %clangxx -fsycl %s -o %t.out
// RUN: %t.out | FileCheck %s

// CHECK: This extended deleter should be called at ctx destruction.

#include <sycl/sycl.hpp>

int main() {
sycl::context c;
sycl::detail::pi::contextSetExtendedDeleter(
c,
[](void *) {
printf("This extended deleter should be called at ctx destruction.");
},
nullptr);
}