Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Update LIT to support the latest BEs - #752

Merged
vladimirlaz merged 3 commits into
intel:intelfrom
vladimirlaz:add_esimd_emu
Jan 25, 2022
Merged

[SYCL] Update LIT to support the latest BEs#752
vladimirlaz merged 3 commits into
intel:intelfrom
vladimirlaz:add_esimd_emu

Conversation

@vladimirlaz

Copy link
Copy Markdown
  • add support for ext_intel_esimd_emulator BE. Only SYCL/ESIMD test
    should be run for this BE;
  • switch to use actual BE names to avoid runtime warning;
  • updated documentation accordingly.

 - add support for ext_intel_esimd_emulator BE. Only SYCL/ESIMD test
should be run for this BE;
 - switch to use actual BE names to avoid runtime warning;
 - updated documentation accordingly.
@vladimirlaz
vladimirlaz requested a review from a team as a code owner January 19, 2022 08:39
@vladimirlaz

Copy link
Copy Markdown
Author

@dongkyunahn-intel, @kbobrovs the testing on with compiler built from intel/llvm#5058 provides the following pass rate for the emulator:

Testing Time: 145.49s
  Unsupported      : 18
  Passed           : 35
  Expectedly Failed:  3
  Failed           : 61

is that expected?

Comment thread SYCL/CMakeLists.txt Outdated
For ESIMD emulator backend only tests from SYCL/ESIMD are run.
@vladimirlaz
vladimirlaz requested a review from bader January 19, 2022 11:01
@vladimirlaz

vladimirlaz commented Jan 19, 2022

Copy link
Copy Markdown
Author

The failure is unrelated to the patch:

  • SYCL :: Plugin/level_zero_batch_barrier.cpp will be fixed after the next compiler nightly is available.

bader
bader previously approved these changes Jan 19, 2022
Comment thread SYCL/lit.cfg.py
kbobrovs
kbobrovs previously approved these changes Jan 19, 2022
@dongkyunahn-intel

Copy link
Copy Markdown

I locally tested esimd_emulator backend with this PR and observed failures from ESIMD kernels - e.g. memory intrinsic from esimd_emulator, time-out, etc while 19 tests passed. I'm going to use my previous PR (#751) for marking such kernels accordingly - either XFAIL or UNSUPPORTED. Please merge this PR after my PR is merged.

@kbobrovs

Copy link
Copy Markdown

right, we want to start running regularly those which can run today, address the rest afterwards.

@kbobrovs kbobrovs left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment

Comment thread SYCL/lit.cfg.py
@vladimirlaz
vladimirlaz merged commit 1349fce into intel:intel Jan 25, 2022
@vladimirlaz
vladimirlaz deleted the add_esimd_emu branch February 2, 2022 10:42
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
 - add support for ext_intel_esimd_emulator BE. Only SYCL/ESIMD test
should be run for this BE;
 - switch to use actual BE names to avoid runtime warning;
 - updated documentation accordingly.
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
 - add support for ext_intel_esimd_emulator BE. Only SYCL/ESIMD test
should be run for this BE;
 - switch to use actual BE names to avoid runtime warning;
 - updated documentation accordingly.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
 - add support for ext_intel_esimd_emulator BE. Only SYCL/ESIMD test
should be run for this BE;
 - switch to use actual BE names to avoid runtime warning;
 - updated documentation accordingly.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants