Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Add test for classes implicitly converted from items in parallel_for #607

Merged
vladimirlaz merged 5 commits into from
Dec 19, 2021
Merged

[SYCL] Add test for classes implicitly converted from items in parallel_for #607

vladimirlaz merged 5 commits into from
Dec 19, 2021

Conversation

@aobolensk
Copy link

@aobolensk aobolensk commented Dec 10, 2021

No description provided.

@aobolensk aobolensk requested a review from a team as a code owner December 10, 2021 09:48
@aobolensk aobolensk mentioned this pull request Dec 10, 2021
Merged
@vladimirlaz
Copy link

vladimirlaz commented Dec 10, 2021

/veify with intel/llvm#5118

@vladimirlaz
Copy link

vladimirlaz commented Dec 10, 2021

/verify with intel/llvm#5118

vladimirlaz
vladimirlaz suggested changes Dec 10, 2021
View reviewed changes
@vladimirlaz
Copy link

vladimirlaz commented Dec 10, 2021

/verify with intel/llvm#5118

@vladimirlaz
Copy link

vladimirlaz commented Dec 10, 2021

/verify with intel/llvm#5118

vladimirlaz
vladimirlaz suggested changes Dec 12, 2021
View reviewed changes
@aobolensk
Copy link
Author

aobolensk commented Dec 13, 2021

/verify with intel/llvm#5118

@vladimirlaz
Copy link

vladimirlaz commented Dec 13, 2021

The tests below failed due to unrelated change.
The PR can be committed after intel/llvm#5118 is submitted and nightly build is ready. The tests have be restarted first.

[2021-12-13T08:32:59.136Z] Failed Tests (7):
[2021-12-13T08:32:59.136Z]   SYCL :: Assert/assert_in_kernels_win.cpp
[2021-12-13T08:32:59.136Z]   SYCL :: Assert/assert_in_multiple_tus_one_ndebug_win.cpp
[2021-12-13T08:32:59.136Z]   SYCL :: Assert/assert_in_multiple_tus_win.cpp
[2021-12-13T08:32:59.136Z]   SYCL :: Assert/assert_in_one_kernel_win.cpp
[2021-12-13T08:32:59.136Z]   SYCL :: Assert/assert_in_simultaneous_kernels_win.cpp
[2021-12-13T08:32:59.136Z]   SYCL :: Assert/assert_in_simultaneously_multiple_tus.cpp
[2021-12-13T08:32:59.136Z]   SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp

vladimirlaz pushed a commit to intel/llvm that referenced this pull request Dec 15, 2021
@aobolensk
[SYCL] Fix support for classes implicitly converted from items in par…
34b93bf 
…allel_for (#5118)

Section 4.9.4.2.2 of the SYCL 2020 specification says that the function object that represents the SYCL kernel function must take any type implicitly converted from SYCL item, representing the currently executing work-item within the range specified by the range parameter. This PR adds that support.

E2E test: intel/llvm-test-suite#607
@vladimirlaz vladimirlaz merged commit 0fe3ffd into intel:intel Dec 19, 2021
myler added a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022
@myler
Merge pull request intel#607 from bb-sycl/xmain
74746a6 
Auto pulldown and update tc files for xmain branch on 20220129
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@aobolensk
[SYCL] Add test for classes implicitly converted from items in parall…
ebd53ab 
…el_for (intel/llvm-test-suite#607)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vladimirlaz vladimirlaz vladimirlaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aobolensk @vladimirlaz