This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove testing of handler::copy with atomic accessors #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handler::copy() method was enabled for dst/src accessors with atomic mode by mistake. The atomic mode is not allowed for explicity copy method of handler class. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
bader
approved these changes
Jan 28, 2021
|
@v-klochkov, there is one failure on Linux, but I don't think it's related to your patch. Anyway, please, make sure this issue is tracked. Tagging @vladimirlaz. |
yuxianch
added a commit
to yuxianch/llvm-test-suite
that referenced
this pull request
Sep 2, 2021
Auto pulldown and update tc files for syclos branch on 20210810
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…lvm-test-suite#126) The handler::copy() method was enabled for dst/src accessors with atomic mode by mistake. The atomic mode is not allowed for explicity copy method of handler class. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler::copy() method was enabled for dst/src accessors with
atomic mode by mistake. The atomic mode is not allowed for explicit copy
method of handler class.
Signed-off-by: Vyacheslav N Klochkov [email protected]