Closed
Conversation
Signed-off-by: Taiju Yamada <tyamada@bi.a.u-tokyo.ac.jp>
Closed
Contributor
|
@liuqinfei, could you review this PR? |
Contributor
|
@cielavenir Hi, Since the original version worked properly before these changes, could you clarify the purpose of extracting a header file? |
Contributor
Author
|
@liuqinfei is sve2 and sve1 are benchmarked properly? though maybe that benchmark might not be required as eor3 is implented on sme1... |
Contributor
Yes, you can use objdump to inspect the .so file for verification. It works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduce gf_nvect_dot_prod_sve_unrolled as include.
current implementation relies on always_inline, which might not be reliable.