Skip to content

GmmGen9Texture overlapping MSAA.NumSamples comparisons #87

@edwarddavidbaker

Description

@edwarddavidbaker

Sorry about bringing this up again. This is a copy of issue #78 . When building gmmlib in Chrome OS the following warning is present.

Source/GmmLib/Texture/GmmGen9Texture.cpp:595:46: warning: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare]
           ((pTexInfo->MSAA.NumSamples == 8) && (pTexInfo->MSAA.NumSamples == 16)) &&
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

MSAA.NumSamples can not be both 8 and 16 at the same time forcing the entire if() to always skip.

  1. From the file history https://github.com/intel/gmmlib/commits/master/Source/GmmLib/Texture/GmmGen9Texture.cpp
    1. Warning originally addressed with f1fa9ea Fix Comparision overlap.
    2. Prior fix overwritten with cac1a15 Xe_HP_SDV Unembargoed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions