Skip to content

[WIP] CI: enable EPID RA#1269

Closed
OverOrion wants to merge 6 commits intointegritee-network:masterfrom
OverOrion:szp/enable-ra-epid
Closed

[WIP] CI: enable EPID RA#1269
OverOrion wants to merge 6 commits intointegritee-network:masterfrom
OverOrion:szp/enable-ra-epid

Conversation

@OverOrion
Copy link
Copy Markdown
Contributor

This PR is basically the same as #1224 but the target branch is different.

Draft until #1222 gets merged.

@OverOrion OverOrion force-pushed the szp/enable-ra-epid branch from 885b99c to ff46e46 Compare April 19, 2023 07:03
@OverOrion
Copy link
Copy Markdown
Contributor Author

OverOrion commented Apr 19, 2023

The tests are failing because GHA secrets are not available in forked repositories.

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

https://docs.github.com/en/actions/security-guides/encrypted-secrets#using-encrypted-secrets-in-a-workflow

Switching to pull_request_target would solve it, but it has some security implications, which we should discuss first.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

@OverOrion
Copy link
Copy Markdown
Contributor Author

Superseded by #1286

@OverOrion OverOrion closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant