Skip to content

Delete ApplicationHealthReconciler #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Delete ApplicationHealthReconciler #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions PROJECT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,10 @@ layout:
projectName: argocd-commenter
repo: github.com/int128/argocd-commenter
resources:
- controller: true
domain: int128.github.io
group: argocdcommenter
kind: ApplicationHealthComment
version: v1
- api:
crdVersion: v1
namespaced: true
controller: true
controller: false
domain: int128.github.io
group: argocdcommenter
kind: ApplicationHealth
Expand All @@ -25,12 +20,17 @@ resources:
- controller: true
domain: int128.github.io
group: argocdcommenter
kind: ApplicationHealthDeployment
kind: ApplicationPhaseComment
version: v1
- controller: true
domain: int128.github.io
group: argocdcommenter
kind: ApplicationPhaseComment
kind: ApplicationHealthComment
version: v1
- controller: true
domain: int128.github.io
group: argocdcommenter
kind: ApplicationHealthDeployment
version: v1
- controller: true
domain: int128.github.io
Expand Down
8 changes: 0 additions & 8 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,6 @@ func main() {
}
notificationClient := notification.NewClient(ghc)

if err = (&controller.ApplicationHealthReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
}).SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "ApplicationHealth")
os.Exit(1)
}

if err = (&controller.ApplicationPhaseCommentReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Expand Down
7 changes: 0 additions & 7 deletions config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,11 @@ rules:
- applicationhealths
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- argocdcommenter.int128.github.io
resources:
- applicationhealths/finalizers
verbs:
- update
- apiGroups:
- argocdcommenter.int128.github.io
resources:
Expand Down
50 changes: 0 additions & 50 deletions internal/controller/applicationhealth_controller.go
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions internal/controller/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,6 @@ var _ = BeforeSuite(func() {
})
Expect(err).ToNot(HaveOccurred())

err = (&ApplicationHealthReconciler{
Client: k8sManager.GetClient(),
Scheme: k8sManager.GetScheme(),
}).SetupWithManager(k8sManager)
Expect(err).ToNot(HaveOccurred())

err = (&ApplicationPhaseCommentReconciler{
Client: k8sManager.GetClient(),
Scheme: k8sManager.GetScheme(),
Expand Down