Add prebuilt-depends for proprietary dependencies.#2444
Add prebuilt-depends for proprietary dependencies.#2444hamishmack merged 2 commits intoinput-output-hk:masterfrom
Conversation
builder/make-config-files.nix
Outdated
| '' + '' | ||
| for p in "''${pkgsHostTarget[@]}"; do | ||
| if [ -e $p/envDep ]; then | ||
| cat $p/envDep >> $configFiles/ghc-environment | ||
| fi | ||
| ${ lib.optionalString component.doExactConfig '' | ||
| if [ -d $p/exactDep ]; then | ||
| cat $p/exactDep/configure-flags >> $configFiles/configure-flags | ||
| cat $p/exactDep/cabal.config >> $configFiles/cabal.config | ||
| fi | ||
| ''} | ||
| done |
There was a problem hiding this comment.
Why did we move this down? Is this due to a quirk how we handle stuff and now with the pre-builts this would need to come later?
| , useLLVM ? ghc.useLLVM or false | ||
| , smallAddressSpace ? false | ||
|
|
||
| , prebuilt-depends ? [] |
There was a problem hiding this comment.
We should add a comment here. As I'm a bit fuzzy on what exactly prebuilt-depends are, I'm not sure I can come up with a good comment yet.
There was a problem hiding this comment.
added a new Note [prebuilt dependencies], does that help?
Add commentary
|
@angerman added a new |
angerman
left a comment
angerman
left a comment
There was a problem hiding this comment.
This is an interesting change. I like it!
I wonder if we somehow can encode the hash of the compiler/rts combination (plus some metadata for error messages) in the produced package to ensure we only ever load proper packages, and can provide some sensible error message?
| # | ||
| # For your build to succeed, your prebuilt-dependencies must meet the following: | ||
| # | ||
| # 1. They are built with the same compiler version and RTS way. |
There was a problem hiding this comment.
| # 1. They are built with the same compiler version and RTS way. | |
| # 1. ⚠️ They are built with the same compiler version and RTS way. ❗ |
This is of the utmost importance, as anything else will fail. I think adding some extra visual notion here is probably a good idea?
Currently you get a less than sensible error message with a GHC version mismatch:
Agreed we should improve this, will take a look |
…put-hk#2444)" This reverts commit 0928a5c.
3 participants
No description provided.