Working recursive test #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquerejeta
force-pushed
the
iquerejeta/in-circuit-verification
branch
from
a808223 to
04bb044
Compare
iquerejeta
commented
Jan 16, 2025
iquerejeta
force-pushed
the
iquerejeta/in-circuit-verification
branch
from
8aa4997 to
e5256cf
Compare
iquerejeta
added a commit
to midnightntwrk/halo2
that referenced
this pull request
Jul 22, 2025
* Working recursive test * Nits * Minimla * Address review comments * Downsize parameters to match size of the circuit * Remove mutable ref from params * Address (simple) review comments * Remove SerdeObject and add read/write functions to hashable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the exposure of certain function and types.
On top of that, it modifies the polynomial commitment scheme proof. We now use the multi-open argument as described in the halo2 book as that is more efficient for in-circuit verification.
The changes include a truncation of challenges in the proof generation/verification.