Skip to content

Refactor getCategoryOptions to return only active categories in a tree structure #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azizerorahman wants to merge 1 commit into from
Closed

Refactor getCategoryOptions to return only active categories in a tree structure #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion innopacks/common/src/Repositories/ProductRepo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,27 @@ public function getBundleItems(Product $product): Collection
*/
public static function getCategoryOptions(): array
{
return CategoryRepo::formatCategoriesForCascader(Category::tree());
// Get only active categories and build tree structure
$activeCategories = Category::where('active', true)
->with(['translation', 'children.translation'])
->orderBy('position')
->get();

// Build tree structure manually since we need to filter by active status
$tree = collect();
$itemsById = $activeCategories->keyBy('id');

foreach ($activeCategories as $category) {
if ($category->parent_id && isset($itemsById[$category->parent_id])) {
if (!isset($itemsById[$category->parent_id]->children)) {
$itemsById[$category->parent_id]->children = collect();
}
$itemsById[$category->parent_id]->children->push($category);
} else {
$tree->push($category);
}
}

return CategoryRepo::formatCategoriesForCascader($tree);
}
}