This repository was archived by the owner on Jan 5, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 71
Add the option to automatically install TICK scripts from a specified directory #8
Open
devth
wants to merge
2
commits into
influxdata:master
Choose a base branch
from
devth:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| {{if .Values.install_tick_scripts.enabled }} | ||
| --- | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ template "fullname" . }}-init | ||
| labels: | ||
| app: {{ template "fullname" . }} | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | ||
| release: "{{ .Release.Name }}" | ||
| heritage: "{{ .Release.Service }}" | ||
| data: | ||
| init.sh: |- | ||
| #!/usr/bin/env bash | ||
| export KAPACITOR_URL="{{ template "fullname" . }}.{{ .Release.Namespace }}:9092" | ||
| ls -al $TICK_DIR | ||
| kapacitor list tasks | ||
|
|
||
| echo "Loading TICK files from $TICK_DIR" | ||
| for f in ${TICK_DIR}/*.tick | ||
| do | ||
| name="$(basename $f)" | ||
| name="${name/.tick/}" | ||
| kapacitor define $name \ | ||
| -type batch \ | ||
| -dbrp telegraf.autogen \ | ||
| -tick $f | ||
| kapacitor enable $name | ||
| done | ||
| echo DONE | ||
| kapacitor list tasks | ||
| --- | ||
| apiVersion: batch/v1 | ||
| kind: Job | ||
| metadata: | ||
| name: {{ template "fullname" . }}-init-job | ||
| labels: | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | ||
| release: {{ .Release.Name | quote }} | ||
| heritage: {{ .Release.Service | quote }} | ||
| app: {{ template "fullname" . }} | ||
| annotations: | ||
| "helm.sh/hook": post-install,post-upgrade | ||
| spec: | ||
| template: | ||
| metadata: | ||
| name: "{{.Release.Name}}" | ||
| labels: | ||
| heritage: {{.Release.Service | quote }} | ||
| release: {{.Release.Name | quote }} | ||
| chart: "{{.Chart.Name}}-{{.Chart.Version}}" | ||
| spec: | ||
| restartPolicy: OnFailure | ||
| containers: | ||
| - name: {{ .Chart.Name }} | ||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" | ||
| imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
| command: ["bash", "/init/init.sh"] | ||
| env: | ||
| - name: TICK_DIR | ||
| value: "{{ .Values.install_tick_scripts.tick_dir }}" | ||
| volumeMounts: | ||
| - name: alerts | ||
| mountPath: /tick | ||
| - name: init | ||
| mountPath: /init | ||
| volumes: | ||
| - name: alerts | ||
| configMap: | ||
| name: {{ template "fullname" . }}-alerts | ||
| - name: init | ||
| configMap: | ||
| name: {{ template "fullname" . }}-init | ||
| {{- end }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a better solution to hardcoding the type and dbrp of the task? In the past I have parsed the type and dbrp values from comments at the top of the TICKscript. Part of the work in influxdata/kapacitor#1313 will be to standardize that behavior.
For example
or
Something along those lines is what I was thinking, but that will probably not be the final result of influxdata/kapacitor#1313.
Technically it is possible to have multiple dbrps values but you can probably leave that out for now as it is uncommon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my purposes I don't (yet) need it to vary, which is why I hardcoded it. I figured I could bake it into the dir structure if I needed to parameterize it someday, e.g.
$TICK_DIR/telegraf/autogen/foo.tick. If you want to bake it into the TICK script itself and parse it out in kapacitor, sounds good to me 😁.