This repository was archived by the owner on Jan 5, 2022. It is now read-only.
telegraf: Allow DaemonSet updateStrategy specification#109
Open
stanislav-zaprudskiy wants to merge 3 commits intoinfluxdata:masterfrom
stanislav-zaprudskiy:allow_configuring_updateStrategy
Open
telegraf: Allow DaemonSet updateStrategy specification#109stanislav-zaprudskiy wants to merge 3 commits intoinfluxdata:masterfrom stanislav-zaprudskiy:allow_configuring_updateStrategy
stanislav-zaprudskiy wants to merge 3 commits intoinfluxdata:masterfrom
stanislav-zaprudskiy:allow_configuring_updateStrategy
Conversation
stanislav-zaprudskiy
changed the title
stanislav-zaprudskiy
changed the title
It turns out it's called different for Deployment objects, compared to DaemonSet objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user may want to update it.
E.g. on my Kubernetes 1.10.9 cluster the DaemonSet got created with
OnDeleteupdate policy for whatever reason, which gave me a hard time finding out why weren't pods getting re-deployed afterhelm upgrade, nevertheless there was thechecksum/configannotation update - until I found helm/helm#2735 (comment).It's even worth to consider enforcing the strategy to be
type: RollingUpdateby default - so to align with expectations fromchecksum/configannotation (which is hard coded ATM).