Skip to content

Fix alerta node hang by adding http timeout and fix time.Duration convert when define topic handler with httppost#2062

Open
Ehekatl wants to merge 3 commits intoinfluxdata:masterfrom
Ehekatl:fix-alert-timeout
Open

Fix alerta node hang by adding http timeout and fix time.Duration convert when define topic handler with httppost#2062
Ehekatl wants to merge 3 commits intoinfluxdata:masterfrom
Ehekatl:fix-alert-timeout

Conversation

@Ehekatl
Copy link

@Ehekatl Ehekatl commented Sep 20, 2018

After run into kapacitor tasks hang several time, I found it's caused by lack of http timeout support in alerta service.

this pr also fixed one of many issues where you can't use timeout in string within topic handler options.
I only did it for http post though.

e.g.

---
id: test
topic: test
kind: post
match: level() == CRITICAL
options:
  endpoint: 'media-as2s'
  timeout: 10s
Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant