This repository was archived by the owner on Feb 27, 2026. It is now read-only.
Merged
Conversation
hiltontj
force-pushed
the
tjh/core-sync-b030287b2
branch
3 times, most recently
from
0d9abb7 to
7074c04
Compare
stuartcarnie
approved these changes
Aug 25, 2025
Contributor
stuartcarnie
left a comment
stuartcarnie
left a comment
There was a problem hiding this comment.
LGTM. Mostly scanned, given this is upstream code from IOx
iox revision range: b030287b2..17d9cec00
hiltontj
force-pushed
the
tjh/core-sync-b030287b2
branch
from
7074c04 to
0c44d0f
Compare
Collaborator
Author
|
Both downstream PRs are ✅ in CI, I amended the commit with the revision range in the commit message. Once CI here is ✅ I will merge this and proceed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The
observability_depscrate was removed in https://github.com/influxdata/influxdb_iox/pull/14600, but I am leaving that change out of this PR as its removal is an invasive change and will be easier to review if done on its own.Downstream PR: