-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: Logging and fsync delay for retention deletion #27114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
651d946
feat: Adds WARN log for series deletion
devanbenz 66c3775
feat: Use 10_000 series constant instead of 24 hours
devanbenz 7893021
feat: Use info log
devanbenz 1742429
feat: Let's add the flush changes to this PR
devanbenz 6ae9a25
feat: adjust comment
devanbenz a53bb61
feat: Use a modulo
devanbenz 07a6c66
feat: Rename vars for better clarity
devanbenz 67414c4
feat: Use f.partitions index directly
devanbenz e6dc601
feat: Remove code dupe, create DeleteSeries which takes and iter and fn
devanbenz d3dc71d
feat: Updates to errors in segment flushing
devanbenz 2c6528a
feat: accidently moved comment
devanbenz d536fad
feat: Lets just revert back to ss.ForEach
devanbenz 519d521
feat: Just log out flush errors no need to exit function
devanbenz a057a53
fix: Don't need locks in for each
devanbenz 617a1b5
chore: fix comment for epoch tracker
devanbenz f9a9530
chore: again
devanbenz 5b919e3
feat: create no flush test
devanbenz ceded32
feat: Update test to use testify
devanbenz aba4bbe
feat: update comment
devanbenz fefb99d
feat: Return flush, add sfile path to log, optimize deleteSeriesRange
devanbenz 352856f
feat: Add locking to FlushSegments
devanbenz ab5406e
feat: remove test logging
devanbenz 71a35e7
feat: Parallel FlushSegments
devanbenz 24fdea2
feat: Add FlushSegments test, use SeriesFilePartitionN for err chan len
devanbenz 881f2af
feat: Remove dead code
devanbenz 5014c28
feat: errChan simplification
devanbenz fbb2aab
feat: Add segment name to error logs
devanbenz 63b90d4
feat: pre-allocate in test
devanbenz 2de8798
feat: one more segment.Flush()
devanbenz 553e13d
feat: fix make for slices
devanbenz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.