Skip to content

feat: Adds LastModifiedOrErr to expose error for LastModified #26623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devanbenz merged 3 commits into from
Jul 25, 2025
Merged

feat: Adds LastModifiedOrErr to expose error for LastModified #26623

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d40ad78
feat: Adds LastModifiedOrErr to expose error for LastModified
devanbenz Jul 23, 2025
13c96af
feat: remove setlastmodified
devanbenz Jul 23, 2025
2326af1
feat: Simplify LastModified, adjust comment, and modify function name
devanbenz Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions tsdb/shard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,11 +460,23 @@ func (s *Shard) ready() error {

// LastModified returns the time when this shard was last modified.
func (s *Shard) LastModified() time.Time {
engine, err := s.Engine()
t, err := s.LastModifiedOrErr()
if err != nil {
return time.Time{}
}
return engine.LastModified()

return t
}

// LastModifiedOrErr returns the time when this shard was last modified or an error.
// See: https://github.com/influxdata/plutonium/pull/4275#discussion_r2214077374
// Previously we would throw away any error from Shard.LastModified
func (s *Shard) LastModifiedOrErr() (time.Time, error) {
engine, err := s.Engine()
if err != nil {
return time.Time{}, err
}
return engine.LastModified(), nil
}

// Index returns a reference to the underlying index. It returns an error if
Expand Down