Skip to content

feat: add system.processing_engine_trigger_arguments table #26604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiltontj merged 1 commit into from
Jul 11, 2025
+275 −70
Merged

feat: add system.processing_engine_trigger_arguments table #26604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ..._table_name_exists,_but_should_error_because_we're_concerned_here_with_system_tables.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
source: influxdb3/tests/cli/mod.rs
expression: output
---
Show command failed: system table 'cpu' not found: please use a valid system table name: ["distinct_caches", "last_caches", "parquet_files", "processing_engine_logs", "processing_engine_triggers", "queries"]
Show command failed: system table 'cpu' not found: please use a valid system table name: ["distinct_caches", "last_caches", "parquet_files", "processing_engine_logs", "processing_engine_trigger_arguments", "processing_engine_triggers", "queries"]
2 changes: 1 addition & 1 deletion influxdb3/tests/cli/snapshots/lib__cli__random_table_name_doesn't_exist,_should_error.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
source: influxdb3/tests/cli/mod.rs
expression: output
---
Show command failed: system table 'meow' not found: please use a valid system table name: ["distinct_caches", "last_caches", "parquet_files", "processing_engine_logs", "processing_engine_triggers", "queries"]
Show command failed: system table 'meow' not found: please use a valid system table name: ["distinct_caches", "last_caches", "parquet_files", "processing_engine_logs", "processing_engine_trigger_arguments", "processing_engine_triggers", "queries"]
3 changes: 3 additions & 0 deletions .../tests/cli/snapshots/lib__cli__summary_should_show_up_to_ten_entries_from_each_table.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ parquet_files summary:
processing_engine_logs summary:
++
++
processing_engine_trigger_arguments summary:
++
++
processing_engine_triggers summary:
++
++
Expand Down
21 changes: 11 additions & 10 deletions ...uxdb3/tests/cli/snapshots/lib__cli__table-list_should_list_system_schema_tables_only.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
source: influxdb3/tests/cli/mod.rs
expression: output
---
+----------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| table_name | column_names |
+----------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| distinct_caches | [table, name, column_ids, column_names, max_cardinality, max_age_seconds] |
| last_caches | [table, name, key_column_ids, key_column_names, value_column_ids, value_column_names, count, ttl] |
| parquet_files | [table_name, path, size_bytes, row_count, min_time, max_time] |
| processing_engine_logs | [event_time, trigger_name, log_level, log_text] |
| processing_engine_triggers | [trigger_name, plugin_filename, trigger_specification, disabled] |
| queries | [id, phase, issue_time, query_type, query_text, partitions, parquet_files, plan_duration, permit_duration, execute_duration, end2end_duration, compute_duration, max_memory, success, running, cancelled, trace_id] |
+----------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| table_name | column_names |
+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| distinct_caches | [table, name, column_ids, column_names, max_cardinality, max_age_seconds] |
| last_caches | [table, name, key_column_ids, key_column_names, value_column_ids, value_column_names, count, ttl] |
| parquet_files | [table_name, path, size_bytes, row_count, min_time, max_time] |
| processing_engine_logs | [event_time, trigger_name, log_level, log_text] |
| processing_engine_trigger_arguments | [trigger_name, argument_key, argument_value] |
| processing_engine_triggers | [trigger_name, plugin_filename, trigger_specification, disabled] |
| queries | [id, phase, issue_time, query_type, query_text, partitions, parquet_files, plan_duration, permit_duration, execute_duration, end2end_duration, compute_duration, max_memory, success, running, cancelled, trace_id] |
+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
37 changes: 19 additions & 18 deletions influxdb3/tests/server/flight.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,24 +112,25 @@ async fn flight() -> Result<(), influxdb3_client::Error> {

assert_batches_sorted_eq!(
[
"+--------------+--------------------+----------------------------+------------+",
"| catalog_name | db_schema_name | table_name | table_type |",
"+--------------+--------------------+----------------------------+------------+",
"| public | information_schema | columns | VIEW |",
"| public | information_schema | df_settings | VIEW |",
"| public | information_schema | parameters | VIEW |",
"| public | information_schema | routines | VIEW |",
"| public | information_schema | schemata | VIEW |",
"| public | information_schema | tables | VIEW |",
"| public | information_schema | views | VIEW |",
"| public | iox | cpu | BASE TABLE |",
"| public | system | distinct_caches | BASE TABLE |",
"| public | system | last_caches | BASE TABLE |",
"| public | system | parquet_files | BASE TABLE |",
"| public | system | processing_engine_logs | BASE TABLE |",
"| public | system | processing_engine_triggers | BASE TABLE |",
"| public | system | queries | BASE TABLE |",
"+--------------+--------------------+----------------------------+------------+",
"+--------------+--------------------+-------------------------------------+------------+",
"| catalog_name | db_schema_name | table_name | table_type |",
"+--------------+--------------------+-------------------------------------+------------+",
"| public | information_schema | columns | VIEW |",
"| public | information_schema | df_settings | VIEW |",
"| public | information_schema | parameters | VIEW |",
"| public | information_schema | routines | VIEW |",
"| public | information_schema | schemata | VIEW |",
"| public | information_schema | tables | VIEW |",
"| public | information_schema | views | VIEW |",
"| public | iox | cpu | BASE TABLE |",
"| public | system | distinct_caches | BASE TABLE |",
"| public | system | last_caches | BASE TABLE |",
"| public | system | parquet_files | BASE TABLE |",
"| public | system | processing_engine_logs | BASE TABLE |",
"| public | system | processing_engine_trigger_arguments | BASE TABLE |",
"| public | system | processing_engine_triggers | BASE TABLE |",
"| public | system | queries | BASE TABLE |",
"+--------------+--------------------+-------------------------------------+------------+",
],
&batches
);
Expand Down
2 changes: 1 addition & 1 deletion ..._table_name_exists,_but_should_error_because_we're_concerned_here_with_system_tables.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
source: influxdb3/tests/server/cli.rs
expression: output
---
Show command failed: system table 'cpu' not found: please use a valid system table name: ["compacted_data", "compaction_events", "distinct_caches", "file_index", "last_caches", "parquet_files", "processing_engine_triggers", "queries"]
Show command failed: system table 'cpu' not found: please use a valid system table name: ["compacted_data", "compaction_events", "distinct_caches", "file_index", "last_caches", "parquet_files", "processing_engine_trigger_arguments", "processing_engine_triggers", "queries"]
2 changes: 1 addition & 1 deletion ...sts/server/snapshots/lib__server__cli__random_table_name_doesn't_exist,_should_error.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
source: influxdb3/tests/server/cli.rs
expression: output
---
Show command failed: system table 'meow' not found: please use a valid system table name: ["compacted_data", "compaction_events", "distinct_caches", "file_index", "last_caches", "parquet_files", "processing_engine_triggers", "queries"]
Show command failed: system table 'meow' not found: please use a valid system table name: ["compacted_data", "compaction_events", "distinct_caches", "file_index", "last_caches", "parquet_files", "processing_engine_trigger_arguments", "processing_engine_triggers", "queries"]
25 changes: 13 additions & 12 deletions .../server/snapshots/lib__server__cli__table-list_should_list_system_schema_tables_only.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@
source: influxdb3/tests/server/cli.rs
expression: output
---
+----------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| table_name | column_names |
+----------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| compacted_data | [table_name, generation_id, generation_level, generation_time, parquet_id, parquet_path, parquet_size_bytes, parquet_row_count, parquet_chunk_time, parquet_min_time, parquet_max_time] |
| compaction_events | [event_time, event_type, event_duration, event_status, event_data] |
| distinct_caches | [table, name, column_ids, column_names, max_cardinality, max_age_seconds] |
| file_index | [database_name, table_name, index_columns, index_column_ids] |
| last_caches | [table, name, key_column_ids, key_column_names, value_column_ids, value_column_names, count, ttl] |
| parquet_files | [table_name, path, size_bytes, row_count, min_time, max_time] |
| processing_engine_triggers | [trigger_name, plugin_filename, trigger_specification, disabled] |
| queries | [id, phase, issue_time, query_type, query_text, partitions, parquet_files, plan_duration, permit_duration, execute_duration, end2end_duration, compute_duration, max_memory, success, running, cancelled, trace_id] |
+----------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| table_name | column_names |
+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| compacted_data | [table_name, generation_id, generation_level, generation_time, parquet_id, parquet_path, parquet_size_bytes, parquet_row_count, parquet_chunk_time, parquet_min_time, parquet_max_time] |
| compaction_events | [event_time, event_type, event_duration, event_status, event_data] |
| distinct_caches | [table, name, column_ids, column_names, max_cardinality, max_age_seconds] |
| file_index | [database_name, table_name, index_columns, index_column_ids] |
| last_caches | [table, name, key_column_ids, key_column_names, value_column_ids, value_column_names, count, ttl] |
| parquet_files | [table_name, path, size_bytes, row_count, min_time, max_time] |
| processing_engine_trigger_arguments | [trigger_name, argument_key, argument_value] |
| processing_engine_triggers | [trigger_name, plugin_filename, trigger_specification, disabled] |
| queries | [id, phase, issue_time, query_type, query_text, partitions, parquet_files, plan_duration, permit_duration, execute_duration, end2end_duration, compute_duration, max_memory, success, running, cancelled, trace_id] |
+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
Loading