Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 0 additions & 100 deletions .ci/vale/styles/InfluxDataDocs/Acronyms.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,106 +49,6 @@ exceptions:
- SCSS
- SDK
- SQL
# SQL/InfluxQL keywords (3-5 uppercase chars trigger this rule)
# These are standard uppercase query clauses, not acronyms.
- ABS
- ADD
- ALL
- AND
- ANY
- ARE
- ASC
- AVG
- BIT
- CASE
- CAST
- COS
- DAY
- DEC
- DESC
- DROP
- ELSE
- END
- EXEC
- EXP
- FOR
- FROM
- FULL
- GRANT
- GROUP
- INNER
- INPUT
- INT
- INTO
- JOIN
- KEY
- LAST
- LEFT
- LEVEL
- LIKE
- LOG
- LOWER
- MATCH
- MAX
- MIN
- MONTH
- NAME
- NAMES
- NOT
- NOW
- "NULL"
- "ON"
- ONLY
- OPEN
- ORDER
- OUTER
- PAD
- POW
- PRIOR
- READ
- REAL
- RIGHT
- ROWS
- SET
- SIN
- SIZE
- SOME
- SPACE
- SUM
- TABLE
- TAN
- THEN
- TIME
- TOP
- TRIM
- "TRUE"
- UNION
- UPPER
- USAGE
- USING
- VALUE
- VIEW
- WHEN
- WHERE
- WITH
- WORK
- WRITE
- YEAR
- ZONE
# InfluxQL-specific
- COUNT
- FILL
- FIRST
- FLOAT
- MEAN
- BEGIN
- ALTER
- CHECK
- CLOSE
- CROSS
- FETCH
- LIMIT
- SHOW
- SSH
- SSL
- SVG
Expand Down
81 changes: 67 additions & 14 deletions .claude/commands/finish.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Complete development work by cleaning up ephemeral documents and preparing for m

This skill handles the end of a development workflow:
1. Reads the full contents of PLAN.md
2. Posts the complete plan details as a PR comment
2. Adds the complete plan details to the PR description (or as a PR comment if the description is already long)
3. Removes ephemeral planning documents
4. Creates a cleanup commit
5. Optionally merges the PR
Expand All @@ -23,7 +23,7 @@ This skill handles the end of a development workflow:

- `--merge`: After cleanup, merge the PR using `gh pr merge --squash`
- `--dry-run`: Preview actions without executing them
- `--no-comment`: Skip posting plan details as PR comment
- `--no-pr-update`: Skip updating PR description

## Steps

Expand Down Expand Up @@ -59,12 +59,42 @@ Read the entire PLAN.md file and preserve all sections:
PLAN_CONTENTS="$(cat PLAN.md)"
```

### 3. Post Plan Details as PR Comment
### 3. Add Plan Details to PR

Post the **complete** PLAN.md contents as a PR comment. Do not summarize or
abbreviate the plan -- include all details so they are preserved after the file
is deleted. Always use a comment (not the PR description) to keep the
description clean and editable.
Add the **complete** PLAN.md contents to the PR. Do not summarize or abbreviate
the plan -- include all details so they are preserved after the file is deleted.

**Strategy:**
- If the PR description is short (under ~2000 characters), append the full plan
to the PR description.
- If the PR description is already long, post the full plan as a PR comment
instead, to keep the description readable.

**Appending to PR description:**

```bash
# Get current PR body
CURRENT_BODY="$(gh pr view --json body -q '.body')"

# Update PR with full plan details appended
gh pr edit --body "$(cat <<EOF
${CURRENT_BODY}

---

## Development Plan

<details>
<summary>Full plan details (from PLAN.md)</summary>

${PLAN_CONTENTS}

</details>
EOF
)"
```

**Posting as PR comment (if description is already long):**

```bash
gh pr comment --body "$(cat <<EOF
Expand Down Expand Up @@ -152,7 +182,7 @@ Agent:

### Actions:
1. Read full PLAN.md contents (42 lines, all sections preserved)
2. Posted full plan details as comment on PR #6789
2. Updated PR #6789 description with complete plan details
3. Removed PLAN.md
4. Created commit: "chore: remove planning docs"
5. Pushed to origin
Expand All @@ -175,7 +205,29 @@ Agent:
Done! PR merged successfully.
```

### Example 3: Incomplete tasks warning
### Example 3: Plan added as comment (long PR description)
```
User: /finish

Agent:
## Finishing development work

### Prerequisites
- Branch: docs-v2-issue6763
- PLAN.md: Found
- PR description: 3200 characters (long)

### Actions:
1. Read full PLAN.md contents
2. PR description already long -- posted full plan as PR comment on #6789
3. Removed PLAN.md
4. Created commit: "chore: remove planning docs"
5. Pushed to origin

Ready for merge!
```

### Example 4: Incomplete tasks warning
```
User: /finish

Expand All @@ -194,7 +246,7 @@ Agent: Proceeding with cleanup...
[continues with normal flow]
```

### Example 4: Dry run
### Example 5: Dry run
```
User: /finish --dry-run

Expand All @@ -203,7 +255,7 @@ Agent:

Would perform the following actions:
1. Read full PLAN.md contents
2. Post full plan details as comment on PR #6789
2. Add complete plan details to PR #6789 description (or comment)
3. Run: git rm PLAN.md
4. Run: git commit -m "chore: remove planning docs"
5. Run: git push
Expand All @@ -214,9 +266,10 @@ No changes made. Run `/finish` to execute.
## Notes

- Always reads full PLAN.md contents before deleting it
- Preserves complete plan details (not just a summary) as a PR comment for future reference
- Always uses a PR comment, keeping the PR description clean and editable
- Preserves complete plan details (not just a summary) in the PR for future reference
- If the PR description is short, appends plan details in a collapsible `<details>` block
- If the PR description is already long, posts the full plan as a PR comment instead
- Squash merge is recommended to keep main branch clean
- The deleted PLAN.md remains in branch history (recoverable if needed)
- Works with GitHub Actions cleanup as a fallback safety net
- Use `--no-comment` to skip posting plan details to the PR
- Use `--no-pr-update` if you want to write the PR description manually
17 changes: 0 additions & 17 deletions .claude/launch.json

This file was deleted.

16 changes: 14 additions & 2 deletions .claude/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,25 @@
]
}
],
"WorktreeCreate": [
{
"hooks": [
{
"type": "command",
"command": "CYPRESS_INSTALL_BINARY=0 yarn install --frozen-lockfile 2>&1 | tail -3",
"timeout": 120,
"statusMessage": "Installing dependencies in new worktree"
}
]
}
],
"SessionStart": [
{
"hooks": [
{
"type": "command",
"command": "[ ! -d node_modules ] && CYPRESS_INSTALL_BINARY=0 PUPPETEER_SKIP_DOWNLOAD=1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 yarn install --frozen-lockfile 2>&1 | tail -3 || true",
"timeout": 300,
"command": "[ ! -d node_modules ] && CYPRESS_INSTALL_BINARY=0 yarn install --frozen-lockfile 2>&1 | tail -3 || true",
"timeout": 120,
"async": true,
"statusMessage": "Checking dependencies"
}
Expand Down
Loading
Loading