Skip to content

fix: remove 10-item display limit in Agent Canvas configuration tables#13049

Merged
KevinHuSh merged 1 commit intoinfiniflow:mainfrom
eviaaaaa:fix/canvas-table-pagination
Feb 9, 2026
Merged

fix: remove 10-item display limit in Agent Canvas configuration tables#13049
KevinHuSh merged 1 commit intoinfiniflow:mainfrom
eviaaaaa:fix/canvas-table-pagination

Conversation

@eviaaaaa
Copy link
Contributor

@eviaaaaa eviaaaaa commented Feb 8, 2026

Description

This PR fixes an issue where the input and variable configuration tables in the Agent Canvas (specifically for Begin, UserFillUp, and Invoke nodes) were truncated at 10 items.

Root Cause:
The tables utilized @tanstack/react-table with getPaginationRowModel() enabled. Since the default page size is 10 and no pagination UI controls were implemented, users could not access items beyond the 10th row.

Solution:
Removed getPaginationRowModel from the table configurations. These lists (inputs/variables) are typically short, so rendering all items in a single scrollable view is the intended behavior.

  • Modified query-table.tsx
  • Modified variable-table.tsx

How to verify

  1. Create a Begin, UserFillUp, or Invoke node in the Agent Canvas.
  2. Add more than 10 input items or variables.
  3. Verify that all items are visible in the list and not truncated at the 10th item.

What kind of change does this PR introduce?

  • Bugfix

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working, pull request that fix bug. labels Feb 8, 2026
@KevinHuSh KevinHuSh requested a review from asiroliu February 9, 2026 02:00
@KevinHuSh KevinHuSh added the ci Continue Integration label Feb 9, 2026
@KevinHuSh KevinHuSh marked this pull request as draft February 9, 2026 02:01
@KevinHuSh KevinHuSh marked this pull request as ready for review February 9, 2026 02:01
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.14%. Comparing base (3828908) to head (e6e2c13).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13049       +/-   ##
===========================================
+ Coverage   33.71%   44.14%   +10.43%     
===========================================
  Files          43       43               
  Lines        9380     9380               
  Branches      107      107               
===========================================
+ Hits         3162     4141      +979     
+ Misses       6209     5220      -989     
- Partials        9       19       +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asiroliu
Copy link
Collaborator

asiroliu commented Feb 9, 2026

LGTM

main(e51a40f):
image

fixed:
image

@KevinHuSh KevinHuSh merged commit 0b55d1e into infiniflow:main Feb 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working, pull request that fix bug. ci Continue Integration size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants