Fix hnsw index could not be mmapped after restart#3274
Merged
yuzhichang merged 4 commits intoinfiniflow:mainfrom Mar 4, 2026
Merged
Fix hnsw index could not be mmapped after restart#3274yuzhichang merged 4 commits intoinfiniflow:mainfrom
yuzhichang merged 4 commits intoinfiniflow:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3274 +/- ##
==========================================
- Coverage 50.54% 42.79% -7.75%
==========================================
Files 731 731
Lines 153402 153403 +1
Branches 27752 27752
==========================================
- Hits 77534 65648 -11886
- Misses 65532 78193 +12661
+ Partials 10336 9562 -774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Because the
hnswbuffer_objdisappears after a restart, when it is reconstructed its state is set tokPersistentinstead ofkMmap. On the relevant code paths you should manually set it tokMmapbefore reading the index.Type of change