Add support for defined but not implemented Symbol.for#252
Merged
fanatid merged 3 commits intoindutny:masterfrom Aug 14, 2020
maxfortun:master
Merged
Add support for defined but not implemented Symbol.for#252fanatid merged 3 commits intoindutny:masterfrom maxfortun:master
fanatid merged 3 commits intoindutny:masterfrom
maxfortun:master
Conversation
Contributor
Author
|
fixes #251 |
Collaborator
|
LGTM, thank you! |
Collaborator
|
Released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbol.foris defined but not implemented in NGINX njs plugin and throws exception.http://hg.nginx.org/njs/file/default/src/njs_symbol.c#l174
Suggestion for
bn.js/lib/bn.js
Line 373 in 5707aed
Wrap in try/catch block and revert to
BN.prototype.inspect = inspect;on error.