Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/bn.js
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,13 @@
dest.red = this.red;
};

BN.prototype._move = function _move (dest) {
dest.words = this.words;
dest.length = this.length;
dest.negative = this.negative;
dest.red = this.red;
};

BN.prototype.clone = function clone () {
var r = new BN(null);
this.copy(r);
Expand Down Expand Up @@ -3169,7 +3176,9 @@

Red.prototype.imod = function imod (a) {
if (this.prime) return this.prime.ireduce(a)._forceRed(this);
return a.umod(this.m)._forceRed(this);

a.umod(this.m)._forceRed(this)._move(a);
return a;
};

Red.prototype.neg = function neg (a) {
Expand Down
9 changes: 9 additions & 0 deletions test/red-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -262,4 +262,13 @@ describe('BN.js/Reduction context', function () {
red.prime.split(input, output);
assert.equal(input.cmp(output), 0);
});

it('imod should change host object', function () {
Copy link
Contributor

@dcousens dcousens Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe indicate (via redIMul)

var red = BN.red(new BN(13));
var a = new BN(2).toRed(red);
var b = new BN(7).toRed(red);
var c = a.redIMul(b);
assert.equal(a.toNumber(), 1);
assert.equal(c.toNumber(), 1);
});
});