bn: introduce in-place pow, .ipow() [WIP]#121
Open
axic wants to merge 1 commit intoindutny:masterfrom
axic:feature/pow-improvements
Open
bn: introduce in-place pow, .ipow() [WIP]#121axic wants to merge 1 commit intoindutny:masterfrom axic:feature/pow-improvements
axic wants to merge 1 commit intoindutny:masterfrom
axic:feature/pow-improvements
Conversation
Owner
|
Benchmarks? Last time I checked it - in-place multiplication was a bit slower than regular one. This is why I haven't used it in elliptic. |
Contributor
Author
|
Perhaps the benchmarks aren't the best. The code is: var x = new bn(13);
add('pow', {
'bn.js pow': function (fixture) {
fixture.a1.clone().pow(x);
},
'bn.js ipow': function (fixture) {
fixture.a1.clone().ipow(x);
},The results are: I do see a bigger difference between |
Owner
|
Yeah, I was even thinking about removing them at all. What's the point of having in-place functions if there are not faster? They are definitely not easier, and not safer to use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes pow() to be in-place and adds the usual wrapper.
Also added a test case for the special 0 power case.