Add .npmignore files to avoid packaging unneeded files#75
Closed
marco-c wants to merge 1 commit intoindutny:masterfrom
Closed
Add .npmignore files to avoid packaging unneeded files#75marco-c wants to merge 1 commit intoindutny:masterfrom
marco-c wants to merge 1 commit intoindutny:masterfrom
Conversation
|
@marco-c OOI, why you added |
Contributor
Author
|
@fanatid they are separate packages, they're published separately from the main package. |
|
oh, really, sorry.. |
indutny
pushed a commit
that referenced
this pull request
Sep 19, 2016
PR-URL: #75 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Owner
|
Landed in c5babea, sorry for delay! |
Contributor
Author
|
Could you publish a new minor release? |
Owner
|
Done! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main package shouldn't need to include the tests and the packages under rfc/.
The rfc packages only need not to include the tests.