Skip to content

Conversation

@lgiommi
Copy link
Contributor

@lgiommi lgiommi commented Jan 30, 2024

Regarding the issue that I have opened under the IM repo and following the suggestions received, I added the force parameter in the destroyInfrastructureAsync function. I tested its usage locally and the force parameters seems to be properly understood. If it is ok also for you, If you can also publish the new version of the package in the maven repository so that I can properly use it in the code of the orchestrator. Thank you.

@grycap-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

@micafer
Copy link
Contributor

micafer commented Jan 30, 2024

test this please

@lgiommi
Copy link
Contributor Author

lgiommi commented Jan 30, 2024

Sorry, what kind of tests do you mean?

@micafer
Copy link
Contributor

micafer commented Jan 31, 2024

retest this please

@micafer
Copy link
Contributor

micafer commented Jan 31, 2024

Sorry, what kind of tests do you mean?

This is a message for the jenkins server.

@micafer micafer merged commit 8de0a71 into indigo-dc:master Jan 31, 2024
@micafer
Copy link
Contributor

micafer commented Jan 31, 2024

I have created the new release; you can update it in any repo you need.

@lgiommi
Copy link
Contributor Author

lgiommi commented Jan 31, 2024

Thank you very much @micafer for the fast reply. Could you please upload the package here. I don't have the permissions. Thanks.

@micafer
Copy link
Contributor

micafer commented Jan 31, 2024

You are wellcome @lgiommi but I don't have permissions either.

@lgiommi
Copy link
Contributor Author

lgiommi commented Jan 31, 2024

Ah ok good. I try to find someone of the indigo-datacloud organization who has permissions.

@lgiommi
Copy link
Contributor Author

lgiommi commented Feb 7, 2024

Hi @micafer. I profit of this pull request to ask you more details about the force parameter. If the IM fails to delete some resources and I use the force parameter equals to true, the infrastructure will be deleted anyway, right? And if there are no problem to delete the infrastructure but I use anyway the force parameter equals to true, the resources will be deleted as usual, or the behavior is different? Thanks

@micafer
Copy link
Contributor

micafer commented Feb 8, 2024

Hi @lgiommi,
It works as you have described, the infrastructure will be deleted from the IM whether all the resources are correctly deleted or not.
But if all the resources are correctly deleted, there is no difference using the force parameter or not.

@lgiommi
Copy link
Contributor Author

lgiommi commented Feb 8, 2024

Ok clear, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants