-
Notifications
You must be signed in to change notification settings - Fork 1
Add force parameter #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
test this please |
|
Sorry, what kind of tests do you mean? |
|
retest this please |
This is a message for the jenkins server. |
|
I have created the new release; you can update it in any repo you need. |
|
You are wellcome @lgiommi but I don't have permissions either. |
|
Ah ok good. I try to find someone of the indigo-datacloud organization who has permissions. |
|
Hi @micafer. I profit of this pull request to ask you more details about the force parameter. If the IM fails to delete some resources and I use the force parameter equals to true, the infrastructure will be deleted anyway, right? And if there are no problem to delete the infrastructure but I use anyway the force parameter equals to true, the resources will be deleted as usual, or the behavior is different? Thanks |
|
Hi @lgiommi, |
|
Ok clear, thanks! |
Regarding the issue that I have opened under the IM repo and following the suggestions received, I added the force parameter in the destroyInfrastructureAsync function. I tested its usage locally and the force parameters seems to be properly understood. If it is ok also for you, If you can also publish the new version of the package in the maven repository so that I can properly use it in the code of the orchestrator. Thank you.