Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the calculation of trims impact in the Ecobalyse scoring system by properly retrieving it from the backend API response rather than deriving it through incorrect circular logic.
Changes:
- Added
trimsImpactsfield to the Ecobalyse API response type - Modified trims calculation to use the value from
result.trimsImpacts.ecsdirectly - Updated tests to include the new
trimsImpactsfield with correct expected values
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/utils/ecobalyse/server-app.js |
Backend Elm code refactoring to properly expose trims impacts in the API response |
src/utils/ecobalyse/api.ts |
Removed circular trims calculation, now uses result.trimsImpacts.ecs directly from API |
src/utils/ecobalyse/api.test.ts |
Updated test mocks to include trimsImpacts field with correct values |
src/types/Ecobalyse.ts |
Added trimsImpacts field to EcobalyseResponse type definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.