[memory]: fix

[tallate]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a memory-related concern by adjusting the default configuration for the memory store. It shifts the system's default behavior to utilize a persistent SQLite database for memory management, enhancing data durability and consistency when no specific memory backend is configured.

Highlights

• Default Memory Backend: Changed the default value for the "MEMORY_BACKEND" environment variable from "inmemory" to "sqlite" within the _create_memory_store function. This ensures that if the environment variable is not explicitly set, the system will now default to using a SQLite-based memory store for persistence.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• aworld/core/context/amni/config.py
  • Updated the default MEMORY_BACKEND from "inmemory" to "sqlite".

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request changes the default memory backend from inmemory to sqlite, making memory persistent by default. This is a reasonable change for many use cases. However, the function's docstring was not updated to reflect this new default, creating a discrepancy between the code and its documentation. I've added a comment with a suggestion to update the docstring for clarity and maintainability.

[gemini-code-assist]

The default memory backend is now sqlite, but the docstring was not updated to reflect this. This can be confusing for other developers. The docstring should be updated to indicate that sqlite is the new default.

Suggested change

	- If MEMORY_BACKEND=sqlite, use SQLiteMemoryStore with DB_PATH (default: ./data/amni_context.db).
	- Otherwise, default to InMemoryMemoryStore for lightweight, ephemeral usage.
	"""
	backend = os.getenv("MEMORY_BACKEND", "inmemory").lower()
	backend = os.getenv("MEMORY_BACKEND", "sqlite").lower()
	- If MEMORY_BACKEND=sqlite (default), use SQLiteMemoryStore with DB_PATH (default: ./data/amni_context.db).
	- If MEMORY_BACKEND=inmemory, use InMemoryMemoryStore for lightweight, ephemeral usage.
	"""
	backend = os.getenv("MEMORY_BACKEND", "sqlite").lower()