Merged
Conversation
…iablePresentation
There was a problem hiding this comment.
Pull request overview
This PR adds support for JWK-based cryptographic binding as a fallback mechanism when DID-based holder resolution is not available. The implementation follows RFC 7800 (Proof-of-Possession Key Semantics for JWTs) by comparing JWK thumbprints from the VP holder field against the VC's cnf.jwk claim.
Changes:
- Added JWK-based validation flow as fallback when DID extraction from VP fails
- Refactored validation logic into smaller, more maintainable methods
- Version bump from 2.0.12 to 2.0.13
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/main/java/es/in2/vcverifier/service/impl/VpServiceImpl.java | Adds JWK-based binding validation with helper methods for JWK extraction, comparison, and conversion; refactors existing DID-based validation into separate methods |
| build.gradle | Version bump to 2.0.13 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
AlbaLopez552
approved these changes
Feb 25, 2026
albertrodriguezdev
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.