impl debug for Pool struc #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
garrensmith
requested changes
Sep 27, 2023
Collaborator
garrensmith
left a comment
garrensmith
left a comment
There was a problem hiding this comment.
I did a quick test and from what I can see you only need:
impl<M: Manager> fmt::Debug for Pool<M> {
Could you remove the other two derive debug and then this is good to go.
Collaborator
|
Awesome. Thanks for the contribution |
Collaborator
|
Latest release is out with this fix https://github.com/importcjj/mobc/releases/tag/0.8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple functionality to add some debug impl to structs I am using in a personal project. Don't need any particular detail but just these structs to have a debug impl.