fix: open connections metrics increment #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
When a new connection was opened, the
mobc_pool_connections_opened_totalmetric was incremented as a gauge, andmobc_pool_connections_openwas incremented as a counter. However,mobc_pool_connections_opened_totalwas described as a counter whilemobc_pool_connections_openwas described as a gauge. Simultaneously,mobc_pool_connections_openis decremented as a gauge when a connection is closed. Therefore,mobc_pool_connections_opened_totalwas incorrectly registered as a gauge instead of a counter.mobc_pool_connections_openwas divided into two different metrics, where the gauge represented the negative number of closed connections, and the counter represented the total number of opened connections.So, this PR increments
mobc_pool_connections_opened_totalas a counter andmobc_pool_connections_openas a gauge when a new pool connection is opened.