Fixes Cannot read property 'some' of undefined#944
Merged
ljharb merged 1 commit intoimport-js:masterfrom Oct 13, 2017
Merged
Conversation
Contributor
Author
|
Oddly, |
ljharb
approved these changes
Oct 13, 2017
Member
|
hmm, I only get 1 failing test locally on master (which I'm fixing momentarily) |
Member
|
@alexgorbatchev would you mind rebasing on top of latest master? |
alexgorbatchev
force-pushed
the
alexgorbatchev/issue-842
branch
from
f89152b to
c246b9e
Compare
Contributor
Author
|
Rebased. I think the tests are failing on Windows. Ran it OSX and it was as you said, just one. No failures on OSX after the rebase. |
2 similar comments
Member
|
We'll have to deal with the windows failures later I guess. |
Contributor
Author
|
Could you please publish this to NPM when you get a chance? |
benmosher
added a commit
that referenced
this pull request
Oct 18, 2017
This was referenced Apr 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #842