[Docs] order: Remove duplicate mention of default#2280
Merged
ljharb merged 1 commit intoimport-js:mainfrom Nov 19, 2021
johnthagen:patch-3
Merged
[Docs] order: Remove duplicate mention of default#2280ljharb merged 1 commit intoimport-js:mainfrom johnthagen:patch-3
order: Remove duplicate mention of default#2280ljharb merged 1 commit intoimport-js:mainfrom
johnthagen:patch-3
Conversation
ljharb
reviewed
Oct 29, 2021
Contributor
Author
|
@ljharb After your feedback, I'm inclined to simply close this PR altogether. Do you concur? |
Member
|
Maybe not; #2280 (comment) |
Contributor
Author
|
Hmm, it seems like for bullet-list options the default is given inline: So, I'm back to being unsure about the PR. |
Codecov Report
@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
- Coverage 94.64% 94.64% -0.01%
==========================================
Files 65 65
Lines 2689 2687 -2
Branches 890 889 -1
==========================================
- Hits 2545 2543 -2
Misses 144 144
Continue to review full report at Codecov.
|
ljharb
approved these changes
Nov 18, 2021
order: Remove duplicate mention of default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update docs for
importrule /newlines-betweenoption. Default value is taken from:eslint-plugin-import/src/rules/order.js
Line 588 in ccb69d9