[Refactor] no-unresolved, no-extraneous-dependencies: moduleVisitor usage#2233
Merged
ljharb merged 1 commit intoimport-js:mainfrom Sep 22, 2021
Merged
[Refactor] no-unresolved, no-extraneous-dependencies: moduleVisitor usage#2233ljharb merged 1 commit intoimport-js:mainfrom
no-unresolved, no-extraneous-dependencies: moduleVisitor usage#2233ljharb merged 1 commit intoimport-js:mainfrom
Conversation
jablko
commented
Sep 21, 2021
| // Do not report when importing types | ||
| if ( | ||
| node.importKind === 'type' || | ||
| (node.parent && node.parent.importKind === 'type') || |
Contributor
Author
There was a problem hiding this comment.
Relatedly this was introduced here and rendered obsolete here, I think.
This comment is describing node.source, which is what node used to be, prior to #1237. That requires the node.parent.importKind term. After, it's the ImportDeclaration/ImportExpression, which satisfies the node.importKind term instead.
ljharb
changed the title
no-unresolved: moduleVisitor usageno-unresolved, no-extraneous-dependencies: moduleVisitor usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I overlooked the second moduleVisitor callback parameter (the ImportDeclaration/ImportExpression) in #2220. Doesn't make a functional difference, just tidier than recovering
nodefromnode.source:eslint-plugin-import/utils/moduleVisitor.js
Line 34 in 4f0f560