Skip to content

[Fix] order: restore default behaviour unless type is in groups#2087

Merged
ljharb merged 1 commit into
import-js:masterfrom
geraintwhite:import-type-option
May 20, 2021
Merged

[Fix] order: restore default behaviour unless type is in groups#2087
ljharb merged 1 commit into
import-js:masterfrom
geraintwhite:import-type-option

Conversation

@geraintwhite

Copy link
Copy Markdown
Contributor

#2070 and #2084

@coveralls

coveralls commented May 17, 2021

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 82.448% when pulling b39770d on grit96:import-type-option into 72b9c3d on benmosher:master.

@geraintwhite
geraintwhite marked this pull request as ready for review May 19, 2021 20:41

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that all changed tests were ones you added in your original PR?

Comment thread tests/src/rules/order.js
Comment thread tests/src/rules/order.js
Comment thread tests/src/rules/order.js
@geraintwhite

Copy link
Copy Markdown
Contributor Author

@ljharb yes, I reverted the test changes from the previous commit and added new ones for the type group

@typeofweb

Copy link
Copy Markdown

Could you, please, stop introducing breaking changes in patch releases? Thank you :P

@ljharb

ljharb commented May 27, 2021

Copy link
Copy Markdown
Member

@mmiszy the word you’re looking for is “bugs”. Feel free to request a refund though.

@typeofweb

Copy link
Copy Markdown

@ljharb there's no need to be sarcastic and condescending.

@ljharb

ljharb commented May 27, 2021

Copy link
Copy Markdown
Member

@mmiszy yes, i agree that your initial comment was both rude and unnecessary.

@typeofweb

Copy link
Copy Markdown

@ljharb I'm sorry that you feel that way about my feedback.

@ljharb

ljharb commented May 27, 2021

Copy link
Copy Markdown
Member

@mmiszy it's not feedback. nobody intentionally introduces breaking changes in a patch release - it's a bug that it's happened. Bugs are unavoidable, and can never be fully stopped, so asking for that can't possibly ever achieve anything except to make someone feel bad that they introduced a bug (which in this case, wasn't even me).

Please stop pretending like your comment was made in good faith. It was clearly snark born out of frustration, and that should be kept to oneself.

@typeofweb

Copy link
Copy Markdown

@ljharb I'm sorry you see it this way 😥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants