Skip to content

Add nested namespace handling for TS#1763

Merged
ljharb merged 1 commit into
import-js:masterfrom
julien1619:feature/fix-nested-ts-namespace
May 31, 2020
Merged

Add nested namespace handling for TS#1763
ljharb merged 1 commit into
import-js:masterfrom
julien1619:feature/fix-nested-ts-namespace

Conversation

@julien1619

Copy link
Copy Markdown
Contributor

Relates to #1673

Add nested namespace declaration handling for Typescript.

@coveralls

coveralls commented May 13, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 97.744% when pulling 5cc3147 on julien1619:feature/fix-nested-ts-namespace into 8118170 on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.006%) to 97.745% when pulling 1c7c10f on julien1619:feature/fix-nested-ts-namespace into 92caa35 on benmosher:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.006%) to 97.745% when pulling 1c7c10f on julien1619:feature/fix-nested-ts-namespace into 92caa35 on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.006%) to 97.745% when pulling 1c7c10f on julien1619:feature/fix-nested-ts-namespace into 92caa35 on benmosher:master.

@julien1619

Copy link
Copy Markdown
Contributor Author

I have one more commit to add so please wait before merging. Thanks!

@ljharb
ljharb marked this pull request as draft May 25, 2020 03:16
@ljharb

ljharb commented May 25, 2020

Copy link
Copy Markdown
Member

@julien1619 when this is ready for review, and tests are passing, please mark the PR as such :-) thanks!

@julien1619

Copy link
Copy Markdown
Contributor Author

I have one last thing to fix, it doesn't crash anymore but it fails to check properly an existing nested namespace (see the last commit with the test that is still failing).

@julien1619

Copy link
Copy Markdown
Contributor Author

Done!

@julien1619
julien1619 marked this pull request as ready for review May 25, 2020 10:16
@ljharb
ljharb force-pushed the feature/fix-nested-ts-namespace branch from 373ee13 to 5cc3147 Compare May 30, 2020 23:12
@ljharb
ljharb merged commit 5cc3147 into import-js:master May 31, 2020
@julien1619
julien1619 deleted the feature/fix-nested-ts-namespace branch May 31, 2020 16:02
@djejaquino

Copy link
Copy Markdown

No releases with this one?

@ljharb

ljharb commented Jun 4, 2020

Copy link
Copy Markdown
Member

@djejaquino nope, not yet. you get what you pay for :-) it will be released when the next release is ready, and when i have time to release it.

@djejaquino

djejaquino commented Jun 4, 2020

Copy link
Copy Markdown

@ljharb I am sorry, did you find my question unpolite or something to come up with such roughness? It was a very simple question with no intention to demand anything out of anyone.

@ljharb

ljharb commented Jun 4, 2020

Copy link
Copy Markdown
Member

@djejaquino i apologize that I came off as rough; in general, asking for a release (especially after a mere 4 days) is indeed impolite, since it's making demands on an unpaid maintainer's time. It's especially complex during a global pandemic and widespread police lawlessness.

I will get it released as soon as possible.

@djejaquino

Copy link
Copy Markdown

@ljharb again, I did not ask for a release, I asked if there is a release.

You do it at your time, I could not care less as I was just evaluating this plugin to maybe use it on a customer project.

Maybe it was a poor choice of words in one’s perspective, and ended up leading you thinking that way, but I am not really used to tiptoe around internet people.

While I appreciate the great job maintainers such as you do for the community, I guess that dealing with condescending people asking for free stuff could create an over sensitive subject for some, leading to misinterpretation.

Stay safe.

@ljharb

ljharb commented Jun 4, 2020

Copy link
Copy Markdown
Member

Apologies for being sensitive about it. In general, you can click on the merge commit, and see if it’s included in any git tags, indicating it’s in a release.

@djejaquino

Copy link
Copy Markdown

100% my fault not checking that. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants