Skip to content

Update no internal modules with exports#1691

Merged
ljharb merged 1 commit into
import-js:masterfrom
adjerbetian:update-no-internal-modules-with-exports
Jun 2, 2020
Merged

Update no internal modules with exports#1691
ljharb merged 1 commit into
import-js:masterfrom
adjerbetian:update-no-internal-modules-with-exports

Conversation

@adjerbetian

@adjerbetian adjerbetian commented Mar 22, 2020

Copy link
Copy Markdown

Resolves #1481

About the breaking change

In the ticket it was suggested to add an option for this behavior. Do you still want this rule behind an option? This behavior with the export feels so natural to me that I would feel strange if it wasn't the default behavior.

Changelog

I update the documentation, but I didn't know how to update the changelog. I wouldn't be against some guidance or help here 😊.

Step down rule

I hesitated to clean the code in /src/rules/no-internal-modules.js to use the step down rule, but I don't want to impose my tastes on this. Do you want me to do it?

@coveralls

coveralls commented Mar 22, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 97.739% when pulling 9dfef28 on adjerbetian:update-no-internal-modules-with-exports into 6dd28ea on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

4 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

@adjerbetian

This comment has been minimized.

@adjerbetian

Copy link
Copy Markdown
Author

@ljharb Can you give me your opinion on this?

@ljharb

ljharb commented Jun 2, 2020

Copy link
Copy Markdown
Member

I agree; this feels like a bugfix.

@ljharb
ljharb merged commit 9dfef28 into import-js:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

No internal module export

3 participants