Skip to content

[New] order: add fixer for destructuring commonjs import#1372

Merged
ljharb merged 1 commit into
import-js:masterfrom
chiawendt:fix-order-destructuring
Jun 3, 2019
Merged

[New] order: add fixer for destructuring commonjs import#1372
ljharb merged 1 commit into
import-js:masterfrom
chiawendt:fix-order-destructuring

Conversation

@chiawendt

Copy link
Copy Markdown
Contributor

fixes #1337

Comment thread src/rules/order.js
@coveralls

coveralls commented May 29, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+2.6%) to 97.803% when pulling 15e5c61 on golopot:fix-order-destructuring into 9a0455e on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.802% when pulling 636b6f6 on golopot:fix-order-destructuring into ca4bf95 on benmosher:master.

2 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.802% when pulling 636b6f6 on golopot:fix-order-destructuring into ca4bf95 on benmosher:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.802% when pulling 636b6f6 on golopot:fix-order-destructuring into ca4bf95 on benmosher:master.

Comment thread src/rules/order.js
Comment thread src/rules/order.js Outdated
@ljharb ljharb changed the title [Fix] order: add fixer for destructuring commonjs import [New] order: add fixer for destructuring commonjs import Jun 3, 2019
@ljharb
ljharb force-pushed the fix-order-destructuring branch from 5361f3f to 15e5c61 Compare June 3, 2019 22:23
@ljharb
ljharb merged commit 15e5c61 into import-js:master Jun 3, 2019
@chiawendt
chiawendt deleted the fix-order-destructuring branch September 7, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Fixer of import/order does not work when destructuring a commomjs module

3 participants